Skip to content

Added more fields to the schema of mlperf training summary results#455

Merged
ShriyaRishab merged 5 commits into
mlcommons:masterfrom
nnasirinvidia:logging_schema_changes
May 7, 2026
Merged

Added more fields to the schema of mlperf training summary results#455
ShriyaRishab merged 5 commits into
mlcommons:masterfrom
nnasirinvidia:logging_schema_changes

Conversation

@nnasirinvidia
Copy link
Copy Markdown
Contributor

Added GBS, RCP, Energy, Samples to Converge and RCP Scaling Factor to the result summarizer.

@nnasirinvidia nnasirinvidia requested review from a team as code owners April 28, 2026 21:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Comment thread mlperf_logging/result_summarizer/result_summarizer.py
Comment thread mlperf_logging/result_summarizer/result_summarizer.py
Comment thread mlperf_logging/result_summarizer/result_summarizer.py
@ShriyaRishab
Copy link
Copy Markdown
Contributor

ShriyaRishab commented Apr 28, 2026

Thanks for creating this, Nasibeh! It needs some cleanup but looks good.

@pgmpablo157321 @mrmhodak here is a draft PR that adds additional fields to the result summarizer csv

Can you please review it?

@ShriyaRishab ShriyaRishab marked this pull request as draft April 28, 2026 21:37
@mrmhodak
Copy link
Copy Markdown

Seems to be doing the right thing.

Can see the output this generates on 5.1 results and review it during the WG meeting?

@nnasirinvidia
Copy link
Copy Markdown
Contributor Author

@ShriyaRishab Can you please share the CLA form that I can sign it?

@ShriyaRishab
Copy link
Copy Markdown
Contributor

@nnasirinvidia this message has the CLA instructions - #455 (comment)

@ShriyaRishab ShriyaRishab marked this pull request as ready for review May 4, 2026 22:01
@ShriyaRishab ShriyaRishab marked this pull request as draft May 4, 2026 22:06
@pgmpablo157321 pgmpablo157321 marked this pull request as ready for review May 7, 2026 00:43
@pgmpablo157321
Copy link
Copy Markdown
Contributor

Examples:

./mlperf-logging/scripts/verify_for_v6.0_training.sh training_results_v5.1/AMD

summary.csv
summary_detailed.csv

./mlperf-logging/scripts/verify_for_v6.0_training.sh training_results_v5.1/MangoBoost/

summary.csv
summary_detailed.csv

In both examples the flag --csv was added to the verify_for_v6.0_training.sh script

Copy link
Copy Markdown
Contributor

@ShriyaRishab ShriyaRishab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in Training WG

@ShriyaRishab ShriyaRishab merged commit 0ed0f9b into mlcommons:master May 7, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants